Open
Conversation
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
This allow distributions to modify install locations. For example, in Debian on x86_64, INSTALL_PREFIX = /usr, and INSTALL_LIB_DIR = /usr/x86_64-linux-gnu/lib. Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
…r priority Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
Many definitions are not correctly marked with `static`. Instead of changing them one-by-one, use `-fvisibility=hidden` is a quicker future-proof fix. Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
vlasky
added a commit
to vlasky/sqlite-vec
that referenced
this pull request
Dec 29, 2025
- Add configurable install paths via INSTALL_PREFIX, INSTALL_LIB_DIR, INSTALL_INCLUDE_DIR, and INSTALL_BIN_DIR variables - Add EXT_CFLAGS to capture user-provided CFLAGS and CPPFLAGS - Hide internal symbols with -fvisibility=hidden, exposing only the public API (sqlite3_vec_init, sqlite3_vec_numpy_init, sqlite3_vec_static_blobs_init) - Remove sudo from install target (users run sudo make install if needed) Inspired by asg017#149 Co-Authored-By: Harry-Chen <cjc-2008@hotmail.com> Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR mainly:
sqlite3_vec_initand friends)These improvements make it easier for distributions to package this great library.